fix: repair all failing utility-library tests#195
Open
stooit wants to merge 1 commit into
Open
Conversation
…te, and validator modules - calculator: throw on division by zero instead of returning Infinity - string-utils: implement truncate and fix wordCount multi-space handling - task-manager: complete missing/incomplete TaskManager methods - date-utils: fix off-by-one in relative formatting; close 23.5h boundary so hours branch never yields '24 hours ago' - validator: fix isEmail (long TLDs) and isUrl (ports) edge cases All 60 tests pass, 0 fail. No test files or dependencies modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library. Final suite: 60 pass / 0 fail, no test files or dependencies modified.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")on a zero divisor instead of returningInfinity.src/string-utils.ts— implementedtruncate(word-boundary truncation with...); fixedwordCountto collapse multiple spaces.src/task-manager.ts— completed missing/incompleteTaskManagermethods.src/date-utils.ts— fixed off-by-one in relative-time formatting. Also closed a latent boundary bug surfaced in review: inputs near 23h59m used to round up to a nonsensical "24 hours ago"; the hours branch now caps at< 23.5hand anything above falls through to the days branch.src/validator.ts— fixedisEmail(long TLDs e.g..museum) andisUrl(URLs with ports) edge cases.Verification
bun test→ 60 pass, 0 fail, 70 assertions.Assumptions